[Rails5] Fix view_exists? into public.

Author: metaskills

TODO.md

@@ -13,6 +13,10 @@ After we get some tests passing
 * Check `sql_for_insert` can do without the table regular expresion.
 * Do we need the `query_requires_identity_insert` check in `execute`?
 * Does the schema cache serialize properly since we conform to that now?
+* What does `supports_materialized_views?` means for SQL Server
+  http://michaeljswart.com/2014/12/materialized-views-in-sql-server/
+  https://blogs.msdn.microsoft.com/ssma/2011/06/20/migrating-oracle-materialized-view-to-sql-server/
+  http://stackoverflow.com/questions/3986366/how-to-create-materialized-views-in-sql-server
 
 
 #### Does Find By SQL Work?

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -21,6 +21,11 @@ def views
           tables('VIEW')
         end
 
+        def view_exists?(table_name)
+          identifier = SQLServer::Utils.extract_identifiers(table_name)
+          super(identifier.object)
+        end
+
         def create_table(table_name, comment: nil, **options)
           res = super
           clear_cache!
@@ -419,11 +424,6 @@ def lowercase_schema_reflection_sql(node)
 
         # === SQLServer Specific (View Reflection) ====================== #
 
-        def view_exists?(table_name)
-          identifier = SQLServer::Utils.extract_identifiers(table_name)
-          views.include? identifier.object
-        end
-
         def view_table_name(table_name)
           view_info = view_information(table_name)
           view_info ? get_table_name(view_info['VIEW_DEFINITION']) : table_name

test/cases/coerced_tests.rb

@@ -657,12 +657,15 @@ class TransactionIsolationTest < ActiveRecord::TestCase
 end
 
 
-
+require 'models/book'
+class Paperback < ActiveRecord::Base; end
 class ViewWithPrimaryKeyTest < ActiveRecord::TestCase
-
+  # We have a few fews and test is poor equality based.
+  coerce_tests! :test_views
+  # This is deprecated and we dont care in thsi version to pass it.
+  coerce_tests! :test_table_exists
   # We do better than ActiveRecord and find the views PK.
   coerce_tests! :test_does_not_assume_id_column_as_primary_key
-
 end