Make sure primary keys are used for pagination even when natural and last column. Closes #123

Author: metaskills

test/cases/specific_schema_test_sqlserver.rb

@@ -62,6 +62,11 @@ class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
         assert record.save
         assert_equal 12, record.reload.id
       end
+      
+      should 'use primary key for row table order in pagination sql' do
+        sql = /OVER \(ORDER BY \[natural_pk_data\]\.\[legacy_id\] ASC\)/
+        assert_sql(sql) { SqlServerNaturalPkData.limit(5).offset(5).all }
+      end
 
     end
 

test/cases/sqlserver_helper.rb

@@ -39,7 +39,7 @@ class FloatData < ActiveRecord::Base ; self.table_name = 'float_data' ; end
 class CustomersView < ActiveRecord::Base ; self.table_name = 'customers_view' ; end
 class StringDefaultsView < ActiveRecord::Base ; self.table_name = 'string_defaults_view' ; end
 class StringDefaultsBigView < ActiveRecord::Base ; self.table_name = 'string_defaults_big_view' ; end
-class SqlServerNaturalPkData < ActiveRecord::Base ; self.table_name = 'natural_pk_data' ; end
+class SqlServerNaturalPkData < ActiveRecord::Base ; self.table_name = 'natural_pk_data' ; self.primary_key = 'legacy_id' ; end
 class SqlServerNaturalPkIntData < ActiveRecord::Base ; self.table_name = 'natural_pk_int_data' ; end
 class SqlServerNaturalPkDataSchema < ActiveRecord::Base ; self.table_name = 'test.sql_server_schema_natural_id' ; end
 class SqlServerQuotedTable < ActiveRecord::Base ; self.table_name = 'quoted-table' ; end