TODO's

Author: Anna

Gemfile

@@ -4,6 +4,7 @@ source 'https://rubygems.org'
 if ENV['RAILS_SOURCE']
   gemspec :path => ENV['RAILS_SOURCE']
 else
+  # Need to get rails source beacause the gem doesn't include tests
   version = ENV['RAILS_VERSION'] || begin
     require 'net/http'
     require 'yaml'

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -50,7 +50,8 @@ def rename_table(table_name, new_name)
 
         def remove_column(table_name, column_name, type = nil)
           raise ArgumentError.new("You must specify at least one column name.  Example: remove_column(:people, :first_name)") if (column_name.is_a? Array)
-          ActiveSupport::Deprecation.warn 'Passing multiple arguments to remove_columns is deprecated, please use just one column name, like: `remove_columns(:posts, :column_name, :type)`', caller if column_name
+          # TODO: this deprecation warning should be fixed or removed
+          # ActiveSupport::Deprecation.warn 'Passing multiple arguments to remove_columns is deprecated, please use just one column name, like: `remove_columns(:posts, :column_name, :type)`', caller if column_name
           remove_check_constraints(table_name, column_name)
           remove_default_constraint(table_name, column_name)
           remove_indexes(table_name, column_name)
@@ -270,6 +271,8 @@ def get_table_name(sql)
           elsif sql =~ /FROM\s+([^\(\s]+)\s*/i
             $1
           else
+            # TODO:
+            puts sql
             nil
           end
         end

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -195,6 +195,9 @@ class SQLServerAdapter < AbstractAdapter
 
       def initialize(connection, logger, pool, config)
         super(connection, logger, pool)
+        # TODO: Is ActiveSupport::Notifications.notifier nil here
+        #       If it is not, does it become nil between here and 'SELECT @@version below'
+        #       If it is, why is it nil here, do we need to change our call to the super impl
         # AbstractAdapter Responsibility
         @schema_cache = Sqlserver::SchemaCache.new self
         @visitor = Arel::Visitors::SQLServer.new self
@@ -203,6 +206,13 @@ def initialize(connection, logger, pool, config)
         @connection_options = config
         connect
         @database_version = select_value 'SELECT @@version', 'SCHEMA'
+
+#         db_ver= "Microsoft SQL Server 2012 - 11.0.2100.60 (X64)
+#   Feb 10 2012 19:39:15
+#   Copyright (c) Microsoft Corporation
+#   Express Edition (64-bit) on Windows NT 6.1 <X64> (Build 7601: Service Pack 1) (Hypervisor)
+# "
+        #TODO
         @database_year = begin
                            if @database_version =~ /Azure/i
                              @sqlserver_azure = true

lib/arel/visitors/sqlserver.rb

@@ -89,7 +89,7 @@ class SQLServer < Arel::Visitors::ToSql
       private
 
       # SQLServer ToSql/Visitor (Overides)
-
+      # TODO: Change for arel 4.0.1
       def visit_Arel_Nodes_SelectStatement(o)
         if complex_count_sql?(o)
           visit_Arel_Nodes_SelectStatementForComplexCount(o)

test/cases/session_test_sqlserver.rb

@@ -1,7 +1,7 @@
 require 'cases/sqlserver_helper'
 require 'action_dispatch'
-require 'active_record/session_store'
-
+# TODO: require 'active_record/session_store'
+# Active Record's Session Store extracted from Rails
 module ActiveRecord
   class SessionStore
     class SessionTest < ActiveRecord::TestCase