Skip to content

Commit 9ff57a9

Browse files
Anna Careywbond
authored andcommitted
The tests now run with rails 4.1.0
removing duplicate standard_dump
1 parent e3bcabf commit 9ff57a9

File tree

6 files changed

+22
-26
lines changed

6 files changed

+22
-26
lines changed

Gemfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ group :development do
4141
gem 'bcrypt-ruby', '~> 3.0.0'
4242
gem 'bench_press'
4343
gem 'mocha'
44-
gem 'minitest-spec-rails'
44+
# TODO: Change back when it's ready
45+
gem 'minitest-spec-rails', git: "https://github.com/metaskills/minitest-spec-rails.git"
4546
gem 'nokogiri'
4647
gem 'rake', '~> 0.9.2'
4748
gem 'rubocop'

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.0.0
1+
4.1.0.pre
Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
1-
$LOAD_PATH.push File.expand_path('../lib', __FILE__)
1+
$:.push File.expand_path("../lib", __FILE__)
22

33
Gem::Specification.new do |s|
44
s.platform = Gem::Platform::RUBY
5-
s.name = 'activerecord-sqlserver-adapter'
6-
s.version = File.read(File.expand_path('../VERSION', __FILE__)).strip
7-
s.summary = 'ActiveRecord SQL Server Adapter. For SQL Server 2005 And Higher.'
8-
s.description = 'ActiveRecord SQL Server Adapter. For SQL Server 2005 And Higher.'
9-
10-
s.authors = ['Ken Collins', 'Anna Carey', 'Murray Steele', 'Shawn Balestracci', 'Joe Rafaniello', 'Tom Ward']
11-
s.email = 'ken@metaskills.net'
12-
s.homepage = 'http://github.com/rails-sqlserver/activerecord-sqlserver-adapter'
13-
14-
s.files = Dir['CHANGELOG', 'MIT-LICENSE', 'README.rdoc', 'VERSION', 'lib/**/*']
5+
s.name = "activerecord-sqlserver-adapter"
6+
s.version = File.read(File.expand_path("../VERSION",__FILE__)).strip
7+
s.summary = "ActiveRecord SQL Server Adapter. For SQL Server 2005 And Higher."
8+
s.description = "ActiveRecord SQL Server Adapter. For SQL Server 2005 And Higher."
9+
10+
s.authors = ['Ken Collins', 'Murray Steele', 'Shawn Balestracci', 'Joe Rafaniello', 'Tom Ward']
11+
s.email = "ken@metaskills.net"
12+
s.homepage = "http://github.com/rails-sqlserver/activerecord-sqlserver-adapter"
13+
14+
s.files = Dir['CHANGELOG', 'MIT-LICENSE', 'README.rdoc', 'VERSION', 'lib/**/*' ]
1515
s.require_path = 'lib'
1616
s.rubyforge_project = 'activerecord-sqlserver-adapter'
17-
18-
s.add_dependency('activerecord', '~> 4.0.0')
19-
s.add_dependency('arel', '~> 4.0.1')
17+
18+
s.add_dependency('activerecord', '~> 4.1.0')
19+
s.add_dependency('arel')
2020
end
21+

test/cases/schema_dumper_test_sqlserver.rb

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
require 'cases/sqlserver_helper'
2+
require 'cases/schema_dumper_test'
23
require 'stringio'
34

5+
46
class SchemaDumperTestSqlserver < ActiveRecord::TestCase
57

68
setup :find_all_tables
@@ -96,15 +98,6 @@ def test_coerced_types_line_up
9698
end
9799
end
98100

99-
private
100-
101-
def standard_dump
102-
stream = StringIO.new
103-
ActiveRecord::SchemaDumper.ignore_tables = []
104-
ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
105-
stream.string
106-
end
107-
108101
end
109102

110103

test/cases/sqlserver_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
require 'active_record/version'
2525
require 'active_record/connection_adapters/abstract_adapter'
2626
require 'minitest-spec-rails'
27+
require 'minitest-spec-rails/init/active_support'
2728
require 'minitest-spec-rails/init/mini_shoulda'
2829
require 'cases/helper'
2930
require 'models/topic'

test/cases/sqlserver_test_case.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require 'active_record/test_case.rb'
1+
require 'cases/test_case.rb'
22

33
# TODO: I'm struggling to figure out how to unsubscribe from only one 'sql.active_record'
44
# This is a temporary hack until we can just get the sqlserver_ignored regex in rails

0 commit comments

Comments
 (0)