Avoiding N'' quoting on char/varchar columns.

Author: metaskills

lib/active_record/connection_adapters/sqlserver/type/char.rb

@@ -8,6 +8,12 @@ def type
             :char
           end
 
+          def type_cast_for_database(value)
+            return if value.nil?
+            return value if value.is_a?(Data)
+            Data.new(super)
+          end
+
           class Data
 
             def initialize(value)

test/cases/specific_schema_test_sqlserver.rb

@@ -120,6 +120,9 @@ def quoted_id
     data = ActiveRecord::Type::SQLServer::Char::Data
     assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(char_col: data.new('T')).first }
     assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(varchar_col: data.new('T')).first }
+    # Taking care of everything.
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(char_col: 'T').first }
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(varchar_col: 'T').first }
   end
 
   # With column names that have spaces