Skip to content

Commit ae0296c

Browse files
committed
Update Rails 5 TODO.
1 parent 096e1b7 commit ae0296c

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

TODO.md

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33

44
Misc remidners while in the heat of adapting the adpater.
55

6-
* Try removing `sp_executesql_sql_type` all together. Do we have to add more types?
7-
* Did we get the schema cache right?
8-
9-
6+
* Review coerced tests.
107

118
## LONG TERM
129

@@ -15,24 +12,7 @@ After we get some tests passing
1512
* Is `primary_keys(table_name)` performant? Contribute to rails for abstract adapter.
1613
* Check `sql_for_insert` can do without the table regular expresion.
1714
* Do we need the `query_requires_identity_insert` check in `execute`?
18-
* Will we have to add more Data types to our dates and use them in `quoted_date` or `quoted_string` or `_type_cast`?
19-
20-
21-
#### Use #without_prepared_statement?
22-
23-
I think we always send everything thru `sp_executesql`. Consider re-evaulating if there are no `binds` that we get any benefit from this. By doing so we also give the users the ability to turn this off completly. Would be neat to see how our prepared statments actually perform again.
24-
25-
```ruby
26-
def without_prepared_statement?(binds)
27-
!prepared_statements || binds.empty?
28-
end
29-
```
30-
31-
Maybe just quick bail to `do_execute`. Maybe related:
32-
33-
* [Do not cache prepared statements that are unlikely to have cache hits](https://github.com/rails/rails/commit/cbcdecd2)
34-
35-
15+
* Does the schema cache serialize properly since we conform to that now?
3616

3717

3818
#### Does Find By SQL Work?

0 commit comments

Comments
 (0)