You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: TODO.md
+2-22Lines changed: 2 additions & 22 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -3,10 +3,7 @@
3
3
4
4
Misc remidners while in the heat of adapting the adpater.
5
5
6
-
* Try removing `sp_executesql_sql_type` all together. Do we have to add more types?
7
-
* Did we get the schema cache right?
8
-
9
-
6
+
* Review coerced tests.
10
7
11
8
## LONG TERM
12
9
@@ -15,24 +12,7 @@ After we get some tests passing
15
12
* Is `primary_keys(table_name)` performant? Contribute to rails for abstract adapter.
16
13
* Check `sql_for_insert` can do without the table regular expresion.
17
14
* Do we need the `query_requires_identity_insert` check in `execute`?
18
-
* Will we have to add more Data types to our dates and use them in `quoted_date` or `quoted_string` or `_type_cast`?
19
-
20
-
21
-
#### Use #without_prepared_statement?
22
-
23
-
I think we always send everything thru `sp_executesql`. Consider re-evaulating if there are no `binds` that we get any benefit from this. By doing so we also give the users the ability to turn this off completly. Would be neat to see how our prepared statments actually perform again.
24
-
25
-
```ruby
26
-
defwithout_prepared_statement?(binds)
27
-
!prepared_statements || binds.empty?
28
-
end
29
-
```
30
-
31
-
Maybe just quick bail to `do_execute`. Maybe related:
32
-
33
-
*[Do not cache prepared statements that are unlikely to have cache hits](https://github.com/rails/rails/commit/cbcdecd2)
34
-
35
-
15
+
* Does the schema cache serialize properly since we conform to that now?
0 commit comments