Skip to content

Commit b2045d6

Browse files
committed
Remove connection defaults and TinyTDS warning.
1 parent 8d713fb commit b2045d6

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11

2+
* 3.2.10 *
3+
4+
* Remove connection defaults for host/username/password. Since we want to suppoert Windows Authentication
5+
and there are just to many possibilities. So we now have to be explicit.
6+
* Remove really old TinyTDS warning.
7+
8+
29
* 3.2.9 *
310

411
* The #remove_default_constraint uses #execute_procedure now. Fixes #223. Thanks @gicappa and @clintmiller.

Rakefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ def test_files
1818
adapter_cases = Dir.glob("#{ar_path}/test/cases/adapters/**/*_test.rb")
1919
files += (ar_cases-adapter_cases).sort
2020
files
21+
# ["test/cases/adapter_test_sqlserver.rb",
22+
# "/Users/kencollins/.rbenv/versions/1.9.3-p194-perf/lib/ruby/gems/1.9.1/bundler/gems/rails-5828e53fec40/activerecord/test/cases/fixtures_test.rb"]
2123
end
2224

2325
task :test => ['test:dblib']

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.2.9
1+
3.2.10

lib/active_record/connection_adapters/sqlserver_adapter.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,11 @@ class Base
2424

2525
def self.sqlserver_connection(config) #:nodoc:
2626
config = config.symbolize_keys
27-
config.reverse_merge! :mode => :dblib, :host => 'localhost', :username => 'sa', :password => ''
27+
config.reverse_merge! :mode => :dblib
2828
mode = config[:mode].to_s.downcase.underscore.to_sym
2929
case mode
3030
when :dblib
3131
require 'tiny_tds'
32-
warn("TinyTds v0.4.3 or higher required. Using #{TinyTds::VERSION}") unless TinyTds::Client.instance_methods.map(&:to_s).include?("active?")
3332
when :odbc
3433
raise ArgumentError, 'Missing :dsn configuration.' unless config.has_key?(:dsn)
3534
require 'odbc'

0 commit comments

Comments
 (0)