Rails2.3 - Implement a custom ActiveRecord::Associations::ClassMethods::JoinDependency::JoinAssociation#aliased_table_name_for method that uses a Regexp.escape so that table/column quoting does not get ignored.

Author: metaskills

CHANGELOG

@@ -1,6 +1,9 @@
 
 MASTER
 
+* Rails2.3 - Implement a custom ActiveRecord::Associations::ClassMethods::JoinDependency::JoinAssociation#aliased_table_name_for
+  method that uses a Regexp.escape so that table/column quoting does not get ignored. [Ken Collins]
+
 * Rails2.3 - Implement #outside_transaction? and a new transaction test case to test some SQL Server 
   basic support while implementing this method. Future home of some savepoint tests too. [Ken Collins]
 

lib/core_ext/active_record.rb

@@ -81,3 +81,49 @@ def add_order_with_sqlserver_unique_checking!(sql, order, scope = :auto)
 end
 
 ActiveRecord::Base.send :include, ActiveRecord::ConnectionAdapters::SQLServerActiveRecordExtensions
+
+
+
+
+require 'active_record/associations'
+
+module ActiveRecord
+  module ConnectionAdapters
+    module SQLServerJoinAssociationChanges
+      
+      def self.included(klass)
+        klass.class_eval do
+          include InstanceMethods
+          alias_method_chain :aliased_table_name_for, :sqlserver_support
+        end
+      end
+      
+      module InstanceMethods
+        
+        protected
+        
+        # An exact copy, except this method has a Regexp escape on the quoted table name.
+        def aliased_table_name_for_with_sqlserver_support(name,suffix=nil)
+          if !parent.table_joins.blank? && parent.table_joins.to_s.downcase =~ %r{join(\s+\w+)?\s+#{Regexp.escape(active_record.connection.quote_table_name(name.downcase))}\son}i
+            @join_dependency.table_aliases[name] += 1
+          end
+          unless @join_dependency.table_aliases[name].zero?
+            # if the table name has been used, then use an alias
+            name = active_record.connection.table_alias_for "#{pluralize(reflection.name)}_#{parent_table_name}#{suffix}"
+            table_index = @join_dependency.table_aliases[name]
+            @join_dependency.table_aliases[name] += 1
+            name = name[0..active_record.connection.table_alias_length-3] + "_#{table_index+1}" if table_index > 0
+          else
+            @join_dependency.table_aliases[name] += 1
+          end
+          name
+        end
+        
+      end
+      
+    end
+  end
+end
+
+ActiveRecord::Associations::ClassMethods::JoinDependency::JoinAssociation.send :include, ActiveRecord::ConnectionAdapters::SQLServerJoinAssociationChanges
+