Fix Deprecation warning - call columns with a table name!

Author: Anna

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -47,7 +47,7 @@ def columns(table_name, name = nil)
         def rename_table(table_name, new_name)
           do_execute "EXEC sp_rename '#{table_name}', '#{new_name}'"
         end
-        
+
         def remove_column(table_name, column_name, type = nil)
           raise ArgumentError.new("You must specify at least one column name.  Example: remove_column(:people, :first_name)") if (column_name.is_a? Array)
           ActiveSupport::Deprecation.warn 'Passing multiple arguments to remove_columns is deprecated, please use just one column name, like: `remove_columns(:posts, :column_name, :type)`', caller if column_name
@@ -59,7 +59,7 @@ def remove_column(table_name, column_name, type = nil)
 
         def change_column(table_name, column_name, type, options = {})
           sql_commands = []
-          column_object = schema_cache.columns[table_name].detect { |c| c.name.to_s == column_name.to_s }
+          column_object = schema_cache .columns(table_name).detect { |c| c.name.to_s == column_name.to_s }
           change_column_sql = "ALTER TABLE #{quote_table_name(table_name)} ALTER COLUMN #{quote_column_name(column_name)} #{type_to_sql(type, options[:limit], options[:precision], options[:scale])}"
           change_column_sql << " NOT NULL" if options[:null] == false
           sql_commands << change_column_sql
@@ -279,7 +279,7 @@ def default_constraint_name(table_name, column_name)
         end
 
         def detect_column_for!(table_name, column_name)
-          unless column = schema_cache.columns[table_name].detect { |c| c.name == column_name.to_s }
+          unless column = schema_cache .columns(table_name).detect { |c| c.name == column_name.to_s }
             raise ActiveRecordError, "No such column: #{table_name}.#{column_name}"
           end
           column
@@ -354,9 +354,9 @@ def set_identity_insert(table_name, enable = true)
         rescue Exception => e
           raise ActiveRecordError, "IDENTITY_INSERT could not be turned #{enable ? 'ON' : 'OFF'} for table #{table_name}"
         end
-
+        #TODO: DEPRECATION WARNING: call columns with a table name!. (called from identity_column at /Users/acarey/code/source/4/activerecord-sqlserver-adapter/lib/active_record/connection_adapters/sqlserver/schema_statements.rb:359)
         def identity_column(table_name)
-          schema_cache.columns[table_name].detect(&:is_identity?)
+          schema_cache.columns(table_name).detect(&:is_identity?)
         end
 
       end