Skip to content

Commit c2e8c63

Browse files
committed
Introduced a bug in 2.2.5 in the #add_order! core ext for ActiveRecord. Fixed now.
1 parent 634f12e commit c2e8c63

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

2000-2005-adapter.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Gem::Specification.new do |s|
22
s.name = "2000-2005-adapter"
3-
s.version = "2.2.5"
4-
s.date = "2009-01-04"
3+
s.version = "2.2.6"
4+
s.date = "2009-01-09"
55
s.summary = "SQL Server 2000 & 2005 Adapter For Rails."
66
s.email = "ken@metaskills.net"
77
s.homepage = "http://github.com/rails-sqlserver/2000-2005-adapter/"

CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ MASTER
44
*
55

66

7+
* 2.2.6 (January 8th, 2008)
8+
9+
* Introduced a bug in 2.2.5 in the #add_order! core ext for ActiveRecord. Fixed [Ken Collins]
10+
11+
712
* 2.2.5 (January 4th, 2009)
813

914
* Added a log_info_schema_queries class attribute and make all queries to INFORMATION_SCHEMA silent by

lib/active_record/connection_adapters/sqlserver_adapter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def simplified_datetime
150150
class SQLServerAdapter < AbstractAdapter
151151

152152
ADAPTER_NAME = 'SQLServer'.freeze
153-
VERSION = '2.2.5'.freeze
153+
VERSION = '2.2.6'.freeze
154154
DATABASE_VERSION_REGEXP = /Microsoft SQL Server\s+(\d{4})/
155155
SUPPORTED_VERSIONS = [2000,2005].freeze
156156
LIMITABLE_TYPES = ['string','integer','float','char','nchar','varchar','nvarchar'].freeze

lib/core_ext/active_record.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def add_order_with_sqlserver_unique_checking!(sql, order, scope = :auto)
6262
sql << " ORDER BY #{unique_order_sql}"
6363
end
6464
else
65-
add_order_without_sqlserver_unique_checking!(order_sql, order, scope)
65+
add_order_without_sqlserver_unique_checking!(sql, order, scope)
6666
end
6767
end
6868

0 commit comments

Comments
 (0)