Rails2.3 - Coerced tests that ensure hash conditions on referenced tables are considered when eager loading with limit/offset. Information on these changes and the ticket in rails are.

Author: metaskills

CHANGELOG

@@ -1,6 +1,11 @@
 
 MASTER
 
+* Rails2.3 - Coerced tests that ensure hash conditions on referenced tables are considered when eager 
+  loading with limit/offset. Information on these changes and the ticket in rails are.
+  http://github.com/rails/rails/commit/9a4d557713acb0fc8e80f61af18094034aca029a
+  http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1404-conditions_tables-doesnt-understand-condition-hashes
+
 * Rails2.3 - Add coerced tests for true/false attributes in selects use SQL Server case statement. [Ken Collins]
 
 * Making sure that smalldatetime types are OK to use. Also fixed a bug in the #view_information method that 

test/cases/eager_association_test_sqlserver.rb

@@ -8,7 +8,11 @@ class EagerAssociationTestSqlserver < ActiveRecord::TestCase
 
 class EagerAssociationTest < ActiveRecord::TestCase
 
-  COERCED_TESTS = [:test_count_with_include]
+  COERCED_TESTS = [
+    :test_count_with_include,
+    :test_eager_with_has_many_and_limit_and_high_offset_and_multiple_array_conditions,
+    :test_eager_with_has_many_and_limit_and_high_offset_and_multiple_hash_conditions
+  ]
 
   include SqlserverCoercedTest
 
@@ -18,5 +22,21 @@ def test_coerced_test_count_with_include
     assert_equal 3, authors(:david).posts_with_comments.count(:conditions => "len(comments.body) > 15")
   end
 
+  def test_coerced_eager_with_has_many_and_limit_and_high_offset_and_multiple_array_conditions
+    assert_queries(2) do
+      posts = Post.find(:all, :include => [ :author, :comments ], :limit => 2, :offset => 10,
+        :conditions => [ "authors.name = ? and comments.body = ?", 'David', 'go crazy' ])
+      assert_equal 0, posts.size
+    end
+  end
+
+  def test_coerced_eager_with_has_many_and_limit_and_high_offset_and_multiple_hash_conditions
+    assert_queries(2) do
+      posts = Post.find(:all, :include => [ :author, :comments ], :limit => 2, :offset => 10,
+        :conditions => { 'authors.name' => 'David', 'comments.body' => 'go crazy' })
+      assert_equal 0, posts.size
+    end
+  end
+  
 
 end