Skip to content

Commit dbf384b

Browse files
committed
The test test_to_sql_on_eager_join was seeing slightly different result in that the SQL was embedded in a call to sp_executesql, which seems ok to me
1 parent c1469b0 commit dbf384b

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

test/cases/relations_test_sqlserver.rb

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33

44

55
class RelationTest < ActiveRecord::TestCase
6-
COERCED_TESTS = [:test_merging_reorders_bind_params]
6+
COERCED_TESTS = [
7+
:test_merging_reorders_bind_params,
8+
:test_to_sql_on_eager_join
9+
]
710
# Until that patch is made to rails we are preventing this test from running in this gem.
811
include SqlserverCoercedTest
912
fixtures :posts
@@ -24,4 +27,12 @@ def test_coerced_merging_reorders_bind_params
2427
merged = left.merge(right)
2528
assert_equal post, merged.first
2629
end
27-
end
30+
31+
def test_coerced_to_sql_on_eager_join
32+
expected = assert_sql {
33+
Post.eager_load(:last_comment).order('comments.id DESC').to_a
34+
}.first
35+
actual = Post.eager_load(:last_comment).order('comments.id DESC').to_sql
36+
assert_equal expected.include?(actual), true
37+
end
38+
end

0 commit comments

Comments
 (0)