Add support for tinyint data types. In MySQL all these types would be boolean, however in our adapter, they will use the full 1 => 255 Fixnum value as you would expect.

Author: metaskills

CHANGELOG

@@ -1,7 +1,8 @@
 
 MASTER
 
-* 
+* Add support for tinyint data types. In MySQL all these types would be boolean, however in 
+  our adapter, they will use the full 1 => 255 Fixnum value as you would expect. [Ken Collins]
 
 
 * 2.2.21 * (September 10th, 2009)

lib/active_record/connection_adapters/sqlserver_adapter/core_ext/dbi.rb

@@ -46,6 +46,14 @@ def self.parse(obj)
               obj.to_s
             end
           end
+          
+          # We want our true 1 to 255 tinyint range.
+          class SqlserverForcedTinyint
+            def self.parse(obj)
+              return nil if ::DBI::Type::Null.parse(obj).nil?
+              obj.to_i
+            end
+          end
 
         end
 
@@ -68,6 +76,8 @@ def type_name_to_module_with_sqlserver_types(type_name)
                 DBI::Type::SqlserverTimestamp
               when /^float|decimal|money$/i
                 DBI::Type::SqlserverForcedString
+              when /^tinyint$/i
+                DBI::Type::SqlserverForcedTinyint
               else
                 type_name_to_module_without_sqlserver_types(type_name)
               end

test/cases/column_test_sqlserver.rb

@@ -1,6 +1,8 @@
 require 'cases/sqlserver_helper'
 require 'models/binary'
 
+class SqlServerEdgeSchema < ActiveRecord::Base; end;
+
 class ColumnTestSqlserver < ActiveRecord::TestCase
 
   def setup
@@ -260,5 +262,19 @@ def setup
 
   end
 
+  context 'For tinyint columns' do
+
+    setup do
+      @tinyint = SqlServerEdgeSchema.columns_hash['tinyint']
+    end
+
+    should 'be all it should be' do
+      assert_equal :integer, @tinyint.type
+      assert_nil @tinyint.scale
+      assert_equal 'tinyint(1)', @tinyint.sql_type
+    end
+
+  end
+  
 
 end

test/cases/specific_schema_test_sqlserver.rb

@@ -68,6 +68,24 @@ class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
 
     end
 
+    context 'with tinyint column' do
+
+      setup do
+        @tiny1 = @edge_class.create! :tinyint => 1
+        @tiny255 = @edge_class.create! :tinyint => 255
+      end
+
+      should 'not treat tinyint like boolean as mysql does' do
+        assert_equal 1, @edge_class.find_by_tinyint(1).tinyint
+        assert_equal 255, @edge_class.find_by_tinyint(255).tinyint
+      end
+      
+      should 'throw an error when going out of our tiny int bounds' do
+        assert_raise(ActiveRecord::StatementInvalid) { @edge_class.create! :tinyint => 256 }
+      end
+      
+    end
+    
   end
 
 

test/schema/sqlserver_specific_schema.rb

@@ -65,6 +65,7 @@
   create_table :sql_server_edge_schemas, :force => true do |t|
     t.string :description
     t.column :bigint, :bigint
+    t.column :tinyint, :tinyint
   end
 
   execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'customers_view') DROP VIEW customers_view"