Adapter doesn't extract default values containing newlines fully

[bfabry]

Line 1084 of sqlserver_adapter.rb attempts to extract the default value for a column from a string returned from the database:

match_data = ci[:default_value].match(/\A(+N?'?(.*?)'?)+\Z/)

It appears that this regex won't correctly match a default value that contains a newline, which for an older version of the adapter would cause it to crash, and for the current version to return nil. Adding m to the end of the regex so that . matches newlines fixed the crash for me

[bfabry]

Noticed this issue is heavily related to #8. Though the fix for that will still not return the correct value if contains a newline

[metaskills]

Could you contribute a patch that would?

[bfabry]

http://github.com/bfabry/2000-2005-adapter

Fix there, but I haven't had time to get the unit tests running yet so it's a bit take-it-or-leave-it.

[metaskills]

Just went to look and could not see anything in that repo??? Perhaps your data got lost from the github migration to rackspace?

[bfabry]

Indeed it did, but it seems it was fixed without my help.

[metaskills]

OK, closing this out.