Added an additional parameter for collation to the create_database method #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a database you can now optionally specify the collation used instead of having to rely on the server's default collation. The latter is not always ideal when dealing with legacy systems.
Contributor
|
I ran the tests with and without ACTIVERECORD_UNITTEST_COLLATION set and it worked both times |
Thanks to @annaswims for spotting it.
Contributor
Author
|
As for the tests passing are you saying that the tests are otherwise good? Or should I revise them? |
Contributor
|
The tests look thorough to me though I'd like to add the disclaimer that I'm new to SQL Server. |
annaswims
added a commit
that referenced
this pull request
Jan 31, 2014
Added an additional parameter for collation to the create_database method
Contributor
Author
|
Awesome. Good to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a database you can now optionally specify the collation used instead of having to rely on the server's default collation. The latter is not always ideal when dealing with legacy systems.
I am new to MiniTest and have done my best to create tests that conform to the general style presented. Any pointers would be much appreciated.
Thanks and hoping you'll (eventually) accept this request.