Skip to content

Fixed Argutement Error in statements.rb #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2014
Merged

Fixed Argutement Error in statements.rb #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/active_record/connection_adapters/sqlserver/database_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ module ActiveRecord
module ConnectionAdapters
module Sqlserver
module DatabaseStatements
def select_rows(sql, name = nil)
raw_select sql, name, [], :fetch => :rows

Copy link

@cmbankester cmbankester Mar 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to change the args to select_rows(sql, opts={}) or something like that? Doing the way you have, there's no way to differentiate between passing in only name or only binds.

def select_rows(sql, name = nil, binds = [])
raw_select sql, name, binds, :fetch => :rows
end

def execute(sql, name = nil)
Expand Down