Add to_s method to SQLServer::Type::Char::Data object #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metaskills with the latest introduction of SQLServer::Type::Char::Data object one of the active record serializers that my app is using stopped working.
I chased the issue down to https://github.com/rails/rails/blob/4-2-stable/activerecord/lib/active_record/type/string.rb#L35 where active record calls
value.to_s
.Since
value
is of typeActiveRecord::ConnectionAdapters::SQLServer::Type::Char::Data
it was not doing what is expected.Since the object doesn't have the
to_s
implementation it was returning a flat"#<ActiveRecord::ConnectionAdapters::SQLServer::Type::Char::Data:0x000000044a0fe8>"
string, instead of returning the actual value from the database, breaking the serializer.This PR adds just that,
to_s
implementation. Thoughts?