Skip to content

Conversation

@takanamito
Copy link
Contributor

@takanamito takanamito commented Jan 12, 2020

Hi. @wpolicarpo

Now, this gem's test is broken.
It occurs a lot of NoMethodError: undefined method split' for nil:NilClass , because of Rails backtrace cleaner silences all backtrace.
https://github.com/seattlerb/minitest/blob/15ed8e4ce504c8313058a1d6fc4918299be34328/lib/minitest/spec.rb#L12

So, I use Rails backtrace in first commit.
And next commit supresses minitest warning.

But test fails with some TinyTds::Error yet.
I will try to success the test in next pull request.

@takanamito takanamito requested a review from wpolicarpo January 16, 2020 04:23
@wpolicarpo wpolicarpo merged commit 319abc4 into rails-sqlserver:master Feb 25, 2020
@wpolicarpo wpolicarpo mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants