Quoted table names containing square brackets need to be regex escaped #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing
activerecord/test/cases/relations_test.rbtests. The tests were failing because table names in the SQL Server adapter use square brackets. The table names were then being used in a regular expression without first being regex escaped causing the regex not to work as expected. This PR escapes the table name in the regex.Table name not suitable for regex:
Table name suitable for regex: