Skip to content

Conversation

@aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Apr 28, 2020

Coerce the TimePrecisionTest#test_no_time_precision_isnt_truncated_on_assignment test as its not applicable for SQL Server.

Test checks that time value isn't truncated if the time column has no precision. However, SQL Server uses default time precision of 7, so value is truncated. The test_time_precision_is_truncated_on_assignment_coerced already tests that the values in columns with precision are truncated correctly.

@aidanharan aidanharan changed the title Rails 6: Time precision test Rails 6: Coerce time no precision test Apr 28, 2020
@aidanharan aidanharan marked this pull request as ready for review April 28, 2020 15:43
@wpolicarpo wpolicarpo merged commit 0f9779e into rails-sqlserver:6-0-dev Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants