From ae93b298f9e833336387e0301343acfcf4598365 Mon Sep 17 00:00:00 2001 From: Aidan Haran Date: Tue, 28 Apr 2020 16:26:36 +0100 Subject: [PATCH 1/2] Coerce test as time has default precision --- test/cases/coerced_tests.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/cases/coerced_tests.rb b/test/cases/coerced_tests.rb index 567357fff..bfa140560 100644 --- a/test/cases/coerced_tests.rb +++ b/test/cases/coerced_tests.rb @@ -1120,6 +1120,9 @@ def test_time_precision_is_truncated_on_assignment_coerced assert_equal 0, foo.start.nsec assert_equal 123457000, foo.finish.nsec end + + # SQL Server uses default precision for time. + coerce_tests! :test_no_time_precision_isnt_truncated_on_assignment end From b5ad6ea4f7ad417599060075d2aabb6030dc7e02 Mon Sep 17 00:00:00 2001 From: Aidan Haran Date: Tue, 28 Apr 2020 16:26:44 +0100 Subject: [PATCH 2/2] Fixed typo --- .../connection_adapters/sqlserver/schema_statements.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/active_record/connection_adapters/sqlserver/schema_statements.rb b/lib/active_record/connection_adapters/sqlserver/schema_statements.rb index a359d86a2..66ca32a47 100644 --- a/lib/active_record/connection_adapters/sqlserver/schema_statements.rb +++ b/lib/active_record/connection_adapters/sqlserver/schema_statements.rb @@ -236,7 +236,7 @@ def type_to_sql(type, limit: nil, precision: nil, scale: nil, **) if (0..7) === precision column_type_sql << "(#{precision})" else - raise(ActiveRecordError, "The dattime2 type has precision of #{precision}. The allowed range of precision is from 0 to 7") + raise(ActiveRecordError, "The datetime2 type has precision of #{precision}. The allowed range of precision is from 0 to 7") end end column_type_sql