Skip to content

Conversation

@mgrunberg
Copy link
Contributor

@mgrunberg mgrunberg commented Dec 29, 2021

Rails have made changes that make the coercion unnecessary

Before (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/4650448486?check_suite_focus=true):

7739 runs, 21027 assertions, 95 failures, 63 errors, 43 skips

After (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/4658531275?check_suite_focus=true)

7739 runs, 21027 assertions, 95 failures, 63 errors, 43 skips

@mgrunberg mgrunberg marked this pull request as ready for review December 29, 2021 12:38
@aidanharan aidanharan merged commit fa939cd into rails-sqlserver:main Dec 29, 2021
@mgrunberg mgrunberg deleted the remove-unnecesary-coerced-test branch January 3, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants