Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upShare internal identifiers and message types with the JavaScript client #117
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks great to me! |
added a commit
that referenced
this pull request
Nov 6, 2015
javan
merged commit 63cdbf8
into
master
Nov 6, 2015
javan
deleted the
shared-constants
branch
Nov 6, 2015
This comment has been minimized.
This comment has been minimized.
dchersey
commented on 365891d
Nov 11, 2015
|
I am using this within a non-sprockets client app (ember-cli) talking to a rails backend. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Perhaps you can lean on your Rails backend to compile the cable js for you? How were you building the js before this commit? |
This comment has been minimized.
This comment has been minimized.
dchersey
replied
Nov 12, 2015
|
Prior to this commit there did not seem to be a dependency on the rails pipeline; I have it in the ember-cli pipeline managed by broccoli.
I am just in the process of getting that to work however so I am not sure that is true but it looks that way. I'm working with a version just prior to this commit.
I'm also working in parallel on putting this latest version into a test example served by rails views and I will see if I can then leverage that.
… On Nov 12, 2015, at 9:28 AM, Javan Makhmali ***@***.*** wrote:
Perhaps you can lean on your Rails backend to compile the cable js for you? How were you building the js before this commit?
—
Reply to this email directly or view it on GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
I'm not familiar with ember-cli or broccoli. Do they support Sprockets directives for requiring other files? https://github.com/rails/actioncable/blob/master/lib/assets/javascripts/cable/consumer.coffee#L1-L4 for example. |
This comment has been minimized.
This comment has been minimized.
dchersey
replied
Nov 17, 2015
|
Ember-cli uses a completely different pipeline for assets, based on javascript. It's kind of 'rails-for-ember' in that it organizes your ember app according to convention-over-configuration and provides its own asset pipeline. It uses a mix of bower, npm and broccoli for different purposes. The net-net though is that there's no ERB preprocessor so actioncable's embedding the internal references in cable.coffee.erb requires sprockets to be in the pipeline somewhere. This effectively limits non-rails-based javascript UIs from being actioncable clients, and I wonder if that is worth gaining the value of injecting these internal values from the ruby code. Fortunately for me, there is ember-cli-rails which serves ember-cli based clients via the rails asset pipeline -- after some fiddling and cursing I managed to get this working :) |
This comment has been minimized.
This comment has been minimized.
|
I think that non sprockets asset manages will need to use precompiled versions of action cable where the erb and sprockets require directives have already been evaluated. I see no reason that a precompiled version of the cable javascripts couldn't be distributed for non rails users. |
This comment has been minimized.
This comment has been minimized.
dchersey
replied
Nov 18, 2015
|
That's a good suggestion; perhaps that should go in the doc as well. Previously to this commit I was including the js in the ember-cli asset pipeline; it was fine because it was all javascript and no ERB. |
javan commentedNov 6, 2015
Move internal messages to
ActionCable::INTERNALand syncwindow.Cableso we don't have to maintain them in two places.cc: @lifo