This repository has been archived by the owner on Nov 1, 2017. It is now read-only.
Fix NoMethodError when using a custom Rails.logger class #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you set your
Rails.logger
to some other class, e.g.ActionCable throws an error when it gets a connection
Because the
TaggedLoggerProxy
class expects the logger to implement atagged
method - which is only true if the logger is an instanceActiveSupport::TaggedLogging
(i.e. the defaultRails.logger
)This PR fixes it by only wrapping loggers that respond to
tagged
in theTaggedLoggerProxy
. An alternative could be to ensure our logger is an instance ofActiveSupport::TaggedLogging
:But it seems like it makes more sense to leave the
Rails.logger
untouched if the app's using a non-default logger?Potentially related to #57