Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master

Dec 11, 2013

  1. Rafael Mendonça França

    Rails 4.1 doesn't respond to default_scoped anymore

    authored December 11, 2013
  2. Rafael Mendonça França

    Only test the distinct case when in Rails 4.0

    authored December 11, 2013
  3. Rafael Mendonça França

    Merge pull request #20 from senny/dont_always_warn_for_distinct_option

    Only pass `:distinct` if it was specified.
    authored December 11, 2013
  4. Rafael Mendonça França

    Merge pull request #21 from senny/require_autoron_before_spec

    require minitest/autorun before minitest/spec to get rid of warnings.
    authored December 11, 2013
  5. Yves Senn

    require minitest/autorun before minitest/spec to get rid of warnings.

    This removes the following warning:
    
    ```
    Warning: you should require 'minitest/autorun' instead.
    Warning: or add 'gem "minitest"' before 'require "minitest/autorun"'
    From:
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/minitest-5.1.0/lib/minitest/spec.rb:3:in `require'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/minitest-5.1.0/lib/minitest/spec.rb:3:in `<top (required)>'
      /Users/senny/Projects/activerecord-deprecated_finders/test/helper.rb:2:in `require'
      /Users/senny/Projects/activerecord-deprecated_finders/test/helper.rb:2:in `<top (required)>'
      /Users/senny/Projects/activerecord-deprecated_finders/test/associations_test.rb:1:in `require'
      /Users/senny/Projects/activerecord-deprecated_finders/test/associations_test.rb:1:in `<top (required)>'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:10:in `require'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:10:in `block (2 levels) in <main>'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:9:in `each'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:9:in `block in <main>'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:4:in `select'
      /Users/senny/Projects/activerecord-deprecated_finders/gemfiles/.bundle/gems/rake-10.1.0/lib/rake/rake_test_loader.rb:4:in `<main>'
    ```
    authored December 11, 2013

Dec 10, 2013

  1. Yves Senn

    Only pass `:distinct` if it was specified.

    This prevents `:distinct` deprecation warnings when the option was not passed at all.
    The prevented deprecation looks like:
    
    ```
    DEPRECATION WARNING: The :distinct option for `Relation#count` is deprecated. Please use `Relation#distinct` instead. (eg. `relation.distinct.count`). (called from calculate at /Users/max/Projects/activerecord-deprecated_finders/lib/active_record/deprecated_finders/relation.rb:84)
    ```
    
    This issue was discovered while working on: rails/rails#13165
    authored December 10, 2013
  2. Rafael Mendonça França

    Run tests against 4-0-stable

    authored December 10, 2013

Aug 27, 2013

  1. Rafael Mendonça França

    Merge pull request #19 from garysweaver/document_dynamic_finder_usage

    filling in some gaps in the documentation [ci skip]
    authored August 27, 2013
  2. Gary S. Weaver

    filling in some gaps in the documentation [ci skip]

    authored August 27, 2013

Jun 11, 2013

  1. Rafael Mendonça França

    Release 1.0.3

    authored June 11, 2013

May 24, 2013

  1. Rafael Mendonça França

    Merge pull request #15 from jetthoughts/project_path

    Show the project path in depreaction warning instead of lib file.
  2. Michael Nikitochkin

    Show the project path in depreaction warning instead of lib relation.

    authored May 24, 2013

Apr 29, 2013

  1. Rafael Mendonça França

    Release 1.0.2

    authored April 29, 2013
  2. Rafael Mendonça França

    Merge pull request #14 from neerajdotname/10304

    better fix for #9994
    authored April 29, 2013
  3. Neeraj Singh

    better fix for #9994

    fixes rails/rails#10304
    
    Fix for #9994 is already applied but it is causing problems.
    
    Previous fix took the approach of applying checking if the
    `CollectionProxy` responds to a method or not. If it does
    then invoke the method on `CollectionProxy` instance. This was
    needed so that the association record could be created for
    hm:t .
    
    However this approach is causing problem. If someone defines a
    method called `find_by_anything` on base class then this method
    is invoked on `CollectionProxy` first. And that's wrong.
    
    In this PR the approach is to send the method to base class and
    if the association is of type hm:t and if the method is
    `find_or_create` or `find_or_creat!` then invoke.
    `save_through_record` on the `proxy_association`.
    authored April 27, 2013

Apr 17, 2013

  1. Rafael Mendonça França

    Release 1.0.1

    authored April 17, 2013
  2. Rafael Mendonça França

    Merge pull request #13 from neerajdotname/fix-test

    fix failing tests
    authored April 17, 2013
  3. Neeraj Singh

    Fix failing tests caused by f97e977

    authored April 17, 2013
  4. Rafael Mendonça França

    Release 1.0.0

    authored April 17, 2013

Apr 05, 2013

  1. Rafael Mendonça França

    Merge pull request #12 from neerajdotname/test-for-prev-commit

    test for previously comitted code
    authored April 05, 2013
  2. Neeraj Singh

    test for previously comitted code

    authored April 05, 2013

Apr 03, 2013

  1. Jon Leighton

    Merge pull request #10 from codeodor/raise-on-mixed-style

    Raise error when mixing block scope with deprecated options
    authored April 03, 2013

Apr 02, 2013

  1. Sammy Larbi

    Raise error when mixing block scope with deprecated options

    authored April 02, 2013

Apr 01, 2013

  1. Rafael Mendonça França

    Merge pull request #7 from neerajdotname/9994

    method should first be invoked on CollectionProxy
    authored April 01, 2013
  2. Rafael Mendonça França

    Merge pull request #8 from codeodor/fix-gemspec-for-edge-rails

    Use the correct gemspec so SQLite3 gets pulled in with bundle install
    authored April 01, 2013

Mar 31, 2013

  1. Sammy Larbi

    Use the correct gemspec so SQLite3 gets pulled in with bundle install

    authored March 31, 2013
  2. Neeraj Singh

    method should first be invoked on CollectionProxy

    This is fix for rails/rails#9994
    authored March 30, 2013

Mar 06, 2013

  1. Rafael Mendonça França

    Fix test with edge version

    Now the symbol in onder is always expanded to prepend the quoted table
    name
    
    Closes #5
    authored March 06, 2013
  2. Rafael Mendonça França

    Notify on campfire

    authored March 06, 2013
  3. Rafael Mendonça França

    Fix Gemfile

    authored March 06, 2013
  4. Rafael Mendonça França

    Test against edge rails and 4.0.0

    authored March 06, 2013

Jan 22, 2013

  1. Rafael Mendonça França

    Version bump to 0.0.3

    authored January 22, 2013
  2. Rafael Mendonça França

    Allow less strict activerecord version

    authored January 22, 2013

Jan 18, 2013

  1. Jon Leighton

    bump to 0.0.2

    authored January 18, 2013
  2. Jon Leighton

    Undeprecate the :extend option

    Suggested by @dhh.
    
    It doesn't affect the generated SQL, so seems reasonable to continue to
    allow it as an association option.
    authored January 18, 2013
Something went wrong with that request. Please try again.