Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update dependencies to fix test suite. #44

Merged
merged 2 commits into from

4 participants

@caike

Reflects changes made to ActiveSupport and the
recently extracted rails-observers gem.

@caike caike Update dependencies for Rails 4 edge.
Reflects changes made to ActiveSupport and the
recently extracted rails-observers gem.
577202c
Gemfile
@@ -11,6 +11,8 @@ end
gem 'activesupport', rails_gem_source.dup
gem 'activemodel', rails_gem_source.dup
+gem 'rails-observers', github: 'rails/rails-observers'
+gem 'journey', github: 'rails/journey'

I see the requirement for observers, but is journey required? Or is it a dependency of something else?

@caike
caike added a note

Looks like it's a dependency for rails-observers. If I remove journey, then I get a dependency error:

Could not find gem 'journey (~> 2.0.0) ruby', which is required by gem 'rails-observers (>= 0) ruby', in any of the sources

@rafaelfranca Owner

I'll fix that in one second.

@rafaelfranca Owner

@caike rails/rails-observers@ad733ef should fix it. You don't need to add jouney there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@guilleiguaran guilleiguaran merged commit df43ecd into rails:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 7, 2012
  1. @caike

    Update dependencies for Rails 4 edge.

    caike authored
    Reflects changes made to ActiveSupport and the
    recently extracted rails-observers gem.
Commits on Dec 8, 2012
  1. @caike
This page is out of date. Refresh to see the latest.
View
1  Gemfile
@@ -11,6 +11,7 @@ end
gem 'activesupport', rails_gem_source.dup
gem 'activemodel', rails_gem_source.dup
+gem 'rails-observers', github: 'rails/rails-observers'
gem 'rake'
# Add your own local bundler stuff
View
2  lib/active_resource/observing.rb
@@ -1,3 +1,5 @@
+require 'rails/observers/active_model/observing'
+
module ActiveResource
module Observing
extend ActiveSupport::Concern
View
2  test/setter_trap.rb
@@ -1,4 +1,4 @@
-class SetterTrap < ActiveSupport::BasicObject
+class SetterTrap < ActiveSupport::ProxyObject
class << self
def rollback_sets(obj)
trapped = new(obj)
Something went wrong with that request. Please try again.