Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Initialize instance with non-prefix attributes in ActiveRecord::Base.build #85

Merged
merged 1 commit into from Nov 30, 2015

Conversation

Projects
None yet
3 participants
Contributor

peterjm commented Jul 22, 2013

ActiveResource::Base.build used to use the attributes to initialize the instance. That functionality was lost when the attributes started to be passed to new_element_path (see fd3616a).

This PR re-adds the functionality.

Contributor

ches commented Oct 28, 2013

👍

Simple patch and very annoying issue.

@peterjm peterjm referenced this pull request in Shopify/shopify_api Jan 10, 2014

Closed

Add Activeresource 4.0.0 compatibility #55

Contributor

ches commented Jan 30, 2014

Bump 😄

rafaelfranca added a commit that referenced this pull request Nov 30, 2015

Merge pull request #85 from peterjm/merge_attributes_during_build
Initialize instance with non-prefix attributes in ActiveRecord::Base.build

@rafaelfranca rafaelfranca merged commit 268bd86 into rails:master Nov 30, 2015

1 check passed

default The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Nov 30, 2015

Merge pull request #85 from peterjm/merge_attributes_during_build
Initialize instance with non-prefix attributes in ActiveRecord::Base.build

@peterjm peterjm deleted the peterjm:merge_attributes_during_build branch Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment