ActiveResource::Base.format.encode is working again #94

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Fivell
Contributor
Fivell commented Sep 4, 2013

use format.encode instead of to_json/to_xml

@Fivell
Contributor
Fivell commented Sep 4, 2013

trying to improve #51

@tkawa tkawa added a commit to tkawa/activeresource-google_spreadsheets that referenced this pull request Dec 26, 2013
@tkawa tkawa Fix for degradation of recent ActiveResource::Base#encode f40ee84
@Fivell
Contributor
Fivell commented Jun 17, 2014

ActiveResource:: Formats::JsonFormat#encode and ActiveResource:: Formats::XmlFormat#encode are useless (https://github.com/rails/activeresource/blob/master/lib/active_resource/formats/json_format.rb#L17), ability to use custom formatters is broken. This PR rollback previous changes and makes #encode work again.

@tkawa
tkawa commented Jun 17, 2014

I totally agree with @Fivell 👍

@rafaelfranca
Member

Could you add a failing test case that show what is not working right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment