This repository has been archived by the owner. It is now read-only.

Add JavaScript direct upload support #81

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@javan
Member

javan commented Jul 27, 2017

πŸ–₯ β†’ ☁️

Fixes #29
Probably fixes #79
Closes #35

@javan

This comment has been minimized.

Show comment
Hide comment
@javan

javan Jul 27, 2017

Member

Demo / example using these direct upload events: https://gist.github.com/javan/5538692cb37a683db15792be8d05761e

Member

javan commented Jul 27, 2017

Demo / example using these direct upload events: https://gist.github.com/javan/5538692cb37a683db15792be8d05761e

@isaac

This comment has been minimized.

Show comment
Hide comment
@isaac

isaac Jul 27, 2017

@javan looks great! Is there a way to start the upload as soon as the user selects the file(s) rather than when the form is submitted?

isaac commented Jul 27, 2017

@javan looks great! Is there a way to start the upload as soon as the user selects the file(s) rather than when the form is submitted?

@dhh dhh merged commit 6262891 into rails:master Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@javan

This comment has been minimized.

Show comment
Hide comment
@javan

javan Jul 28, 2017

Member

@isaac not currently, but you can implement that yourself by handling a file input's change event and creating DirectUploads for its Files. See DirectUploadController for example usage.

Member

javan commented Jul 28, 2017

@isaac not currently, but you can implement that yourself by handling a file input's change event and creating DirectUploads for its Files. See DirectUploadController for example usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.