Permalink
Browse files

limit members of the AST are visited

  • Loading branch information...
1 parent 4018b5d commit 0c205386f33a6c287de3449bcd9a12b5d85cc08e @tenderlove tenderlove committed Dec 7, 2010
Showing with 6 additions and 0 deletions.
  1. +6 −0 History.txt
View
@@ -1,3 +1,9 @@
+== 2.0.7 (unreleased)
+
+* Bug Fixes
+
+ * Limit members are visited
+
== 2.0.6 12/01/2010
* Bug Fixes

1 comment on commit 0c20538

I remember ActiveRecord had tests that a #to_i conversion was done on limit/offset which was good for params string options be passed down. Is this still the case? I noticed your tests just visit the object so "20-xyx" would not be 20 anymore. Does it not matter for other DBs to have LIMIT '20' vs LIMIT 20? In the case of SQL Server it will come out to TOP (N'20') if a string is passed in, unless I am missing something at this stage and what I am seeing for tests under 2.0.2 and passing :limit => '20'

Please sign in to comment.