Permalink
Browse files

Make "not" apply to the whole sub-expression when generating sql.

  • Loading branch information...
rgrempel authored and tenderlove committed Dec 4, 2010
1 parent 516ae52 commit c28fe4cbbb1121394c6bb14403350723f9ecce4c
Showing with 8 additions and 2 deletions.
  1. +1 −1 lib/arel/visitors/to_sql.rb
  2. +7 −1 test/visitors/test_to_sql.rb
@@ -192,7 +192,7 @@ def visit_Arel_Nodes_On o
end
def visit_Arel_Nodes_Not o
- "NOT #{visit o.expr}"
+ "NOT (#{visit o.expr})"
end
def visit_Arel_Table o
@@ -40,7 +40,13 @@ module Visitors
it "should visit_Not" do
sql = @visitor.accept Nodes::Not.new(Arel.sql("foo"))
- sql.must_be_like "NOT foo"
+ sql.must_be_like "NOT (foo)"
+ end
+
+ it "should apply Not to the whole expression" do
+ node = Nodes::And.new @attr.eq(10), @attr.eq(11)
+ sql = @visitor.accept Nodes::Not.new(node)
+ sql.must_be_like %{NOT ("users"."id" = 10 AND "users"."id" = 11)}
end
it "should visit_As" do

0 comments on commit c28fe4c

Please sign in to comment.