Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactor of Arel::Visitors::ToSql#accept breaks Arel::SelectManager#where_clauses #79

Closed
jsanders opened this Issue Aug 29, 2011 · 1 comment

Comments

Projects
None yet
1 participant

This commit - 7941132 - changed the expectation of what is passed to ToSql#new, and the call to ToSql#new in SelectManager#where_clauses was not changed appropriately. Looks like Compatibility::Wheres#each probably has the same problem. SelectManager#where_clauses is deprecated, but should still work properly, unless it is going to be removed entirely.

Fixed in 8ab89f5

@jsanders jsanders closed this Aug 30, 2011

jsanders pushed a commit to jsanders/arel that referenced this issue Jan 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment