Skip to content

Untitled #1

Closed
wants to merge 39 commits into from
@albus522

I believe this is probably a bug fix for Arel::Table#as so that the parent engine is maintained within the alias table

myronmarston and others added some commits Jun 24, 2010
@myronmarston myronmarston Document how to add support for non-standard AR DB adapters. bd08e5b
@miloops miloops Improve blocks usage. 363af00
@miloops miloops Performance: use blocks only when needed. 2c0feac
@miloops miloops Use block_given? instead defining block. 93aaabc
@jeremy jeremy Merge remote branch 'brynary/master' 7e40720
@rsim rsim fixed OracleCompiler according to latest SqlCompiler changes 39c2a46
@tenderlove tenderlove fixing warning b809bc3
@brynary brynary Merge remote branch 'rails/master'
Conflicts:
	lib/arel/algebra/relations/operations/having.rb
	lib/arel/algebra/relations/operations/lock.rb
	lib/arel/algebra/relations/operations/where.rb
	lib/arel/algebra/relations/relation.rb
	lib/arel/algebra/relations/utilities/compound.rb
	lib/arel/engines/sql/engine.rb
	lib/arel/engines/sql/relations/compiler.rb
ae3adbf
@tenderlove tenderlove fixing call to primary key 2be965c
@tenderlove tenderlove bumping version to rc1 16a2d5d
@svenfuchs svenfuchs revert 19c5a95 and add tests
Arel::Table needs to be able to detect tables that are created after the model has loaded (i.e. Arel::Table has been instantiated through, e.g., #default_scope in ActiveRecord)
4b47640
@svenfuchs svenfuchs don't leave @options uninitialized on Table
if Table was initialized with an engine as a second argument then @options was left uninitialized (nil) and calling #as crashed with a NoMethodError for nil:NilClass
3b1b245
@jeremy jeremy Merge remote branch 'rails/master' ea84a7f
@jeremy jeremy Ruby 1.8.8: silence Array("string") deprecation warning aebd5d2
@tenderlove tenderlove skipping Array() since that breaks multiline SQL [#5457 state:resolved] 6333a2b
@jeremy jeremy Merge remote branch 'rails/master'
Conflicts:
	lib/arel/algebra/relations/relation.rb
94cd4fa
@ebeigarts

This fails on Oracle:
'Arel::Relation Relation::Operable#where manufactures a where relation' FAILED
expected
SELECT "USERS"."ID", "USERS"."NAME" FROM "USERS" WHERE intern net
to be like
SELECT "users"."id", "users"."name" FROM "users" WHERE intern net

Ruby on Rails member

Fixed here: be7e662

@fredwu
Ruby on Rails member

Are you sure? bundle install works fine for me from rails master.

You're right, it was actually caused by a bundler issue. Please ignore my request. :)

Ruby on Rails member

No problem. I've removed the dependency on active support, so hopefully this won't be a bother anyway. ;-)

@vendethiel

Little Typo: "users"."name" = E'name'

@nertzy
nertzy commented May 18, 2013

Should this be closed? Looks like noise at this point...

@rafaelfranca
Ruby on Rails member

Yes. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.