Skip to content

Remove deprecated Relation module #113

Merged
merged 1 commit into from Mar 27, 2012

3 participants

@xuanxu
xuanxu commented Mar 27, 2012

Deprecated Relation module is not needed anymore if reference is removed from Rails.

related PR in rails repo: rails/rails#5610

@jeremy
Ruby on Rails member
jeremy commented Mar 27, 2012

Safe to remove now, @tenderlove?

@tenderlove
Ruby on Rails member

Yes!

@tenderlove tenderlove merged commit 9978fc4 into rails:master Mar 27, 2012
@tenderlove
Ruby on Rails member

Apparently activerecord still depends on this constant. So I'm reverting for now.

Unfortunately the AR tests don't blow up, so we're missing some coverage in the tests. :(

@tenderlove tenderlove added a commit that referenced this pull request Mar 27, 2012
@tenderlove tenderlove Revert "Merge pull request #113 from xuanxu/remove_relation"
This reverts commit 9978fc4, reversing
changes made to b454667.
6e8d158
@xuanxu
xuanxu commented Mar 27, 2012

There's a PR to remove that line: rails/rails#5610 The change did not brake any tests so I thought we were done. I'll take a deeper look. What should be used instead of Arel::Relation there? ActiveRecord::Relation?

@tenderlove
Ruby on Rails member

Awesome, thanks! I'll merge that, then revert my revert! :-D

@tenderlove tenderlove added a commit that referenced this pull request Mar 27, 2012
@tenderlove tenderlove Revert "Revert "Merge pull request #113 from xuanxu/remove_relation""
This reverts commit 6e8d158.
d43ae58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.