Remove some test warnings #116

Merged
merged 1 commit into from Nov 17, 2012

Projects

None yet

1 participant

@carlosantoniodasilva

These table variables are giving warnings and doesn't seem to be required for such tests.

I'm also getting this warning when running tests:

arel/lib/arel/nodes/window.rb:21: warning: instance variable @frame not initialized

The warning is in this method:

def frame(expr)
  raise ArgumentError, "Window frame cannot be set more than once" if @frame
  @framing = expr
end

Where I believe the @frame variable should actually be framing, but this gives me 2 failing tests in test_select_manager.rb. I'll try to take a look into this later, but any directions are welcome. Thanks.

@carlosantoniodasilva carlosantoniodasilva merged commit 04dbdd9 into rails:master Nov 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment