Fix for incompatibility between Sequel and Arel in Rails 3.2.8. #135

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

fimmtiu commented Sep 6, 2012

Fixes the issue introduced by commit rails/rails@a1c05dd and discussed in issue rails/arel#133.

It's not the ideal solution, but it's only three lines and seems to do the trick.

(And yes, there are apps that use both Sequel and ActiveRecord.)

Collaborator

ernie commented Sep 6, 2012

I'm -1 on this. I offered that solution as something that Sequel could patch in via a compatibility fix, but otherwise, this discussion (and any fix) should remain on AR, where the node gets created, not ARel, IMHO.

Owner

tenderlove commented Sep 7, 2012

Yes. If anything, this is an AR bug, not an ARel bug. Let's fix the issue in the correct place.

Aaron Patterson
http://tenderlovemaking.com/
I'm on an iPhone so I apologize for top posting.

On Sep 6, 2012, at 3:58 PM, Ernie Miller notifications@github.com wrote:

I'm -1 on this. I offered that solution as something that Sequel could patch in via a compatibility fix, but otherwise, this discussion (and any fix) should remain on AR, where the node gets created, not ARel, IMHO.


Reply to this email directly or view it on GitHub.

sheerun commented Oct 21, 2013

I guess this should be closed

@ernie ernie closed this Oct 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment