Add "create_or" method #176

wants to merge 1 commit into from

5 participants


By analogy with "create_and"


I'm 👍 on the factory method but you don't need to create the Or node -- it already exists and is a binary type (left, right) -- see


Multiple children aren't supported for Or nodes, nor should they be. You'd want to update this PR to match the Or node's initializer signature:

def create_or left, right left, right



Looks good to merge.


@ernie , so can you merge it?

Ruby on Rails member

Yes, seem good to merge. Squash your commits please.


@seuros done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment