Add support for lock in Update and Delete. #221

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@pschambacher

MSSQL allow you to specify a lock hint for SELECT, UPDATE and DELETE.
To support this, UpdateStatement, DeleteStatement and their manager counterpart need to allow a lock value.

I've extracted the lock business in a separate module included in the SelectTatement, UpdateStatement and DeleteStatement.

This pull request is the first step for this: jruby/activerecord-jdbc-adapter#494
When accepted I'll apply the same modification for the 4-0-stable branch and master branch.

@pschambacher pschambacher Add support for lock in Update and Delete.
MSSQL allow you to specify a lock hint for SELECT, UPDATE and DELETE.
To support this, UpdateStatement, DeleteStatement and their manager
counterpart need to allow a lock value.
afd8b17
@pschambacher

Feedback ? Remarks ? Something ?

@vipulnsward
Member

lgtm. If I am not wrong 3.0-stable branch isn't maintained anymore. Maybe @rafaelfranca can confirm.

@tamird
tamird commented Sep 16, 2014

@pschambacher could you open this against master first and then backport as appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment