Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Fix for issue #223. Handle situation where windows is nil. #225

wants to merge 1 commit into from

3 participants


I modified the check on the windows array to handle the situation that was nil. This was causing breakage for me in when trying to use 3.0.3


How is the windows array being set to nil? It is initialized to [] here.


I'm not sure exactly and would have to look to find a stacktrace. My hunch is that it was through some other code setting the windows instance variable through the attr_accessor.


3-0-stable is no longer maintained, correct? let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/arel/visitors/to_sql.rb
2  lib/arel/visitors/to_sql.rb
@@ -136,7 +136,7 @@ def visit_Arel_Nodes_SelectCore o
("WHERE #{ { |x| visit x }.join ' AND ' }" unless o.wheres.empty?),
("GROUP BY #{ { |x| visit x }.join ', ' }" unless o.groups.empty?),
(visit(o.having) if o.having),
- ("WINDOW #{ { |x| visit x }.join ', ' }" unless
+ ("WINDOW #{ { |x| visit x }.join ', ' }" unless Array(
].compact.join ' '
Something went wrong with that request. Please try again.