Stop calling to_s on aliases, require them to be strings already. #48

Merged
merged 1 commit into from Apr 29, 2011

Projects

None yet

2 participants

@ernie
Collaborator
ernie commented Apr 29, 2011

As discussed. I ran the AR test suite against this version of ARel, and was pleasantly surprised to see no failures -- looks like any calls to #as are already being done with strings -- or we don't have test coverage on those calls -- hopefully the former. :)

@tenderlove
Member

Great! I'll merge it.

@tenderlove tenderlove added a commit that referenced this pull request Apr 29, 2011
@tenderlove tenderlove Merged pull request #48 from ernie/down_with_to_s.
Stop calling to_s on aliases, require them to be strings already.
6330a18
@tenderlove tenderlove merged commit 6330a18 into rails:master Apr 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment