alias name based on column name #76

Closed
wants to merge 1 commit into
from

6 participants

@skorfmann

build the alias name based on column name, instead of hard-coded name ("avg/min/max/sum_id)

@vipulnsward
Ruby on Rails member

This seems like a good idea. No movement for the last 2 years though.

@a3gis

How would the alias name behave in presence of a JOIN? (two colums sharing the same name)? I'll add a test asap.

@matthewd
Ruby on Rails member

As is, this will break on columns whose names need to be quoted

@tamird

This PR is now obsolete; the alias is no longer passed in this initialization. also, i think i'm going to introduce another PR to remove the aliaz parameter from this constructor as I did for extract.

Good to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment