Move commands under Rails::ConsoleMethods namespace #15

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

pixeltrix commented Dec 22, 2012

There's an existing module for the console methods app and helper
so it makes sense to move the commands under this module as commands.rb
already exists for other commands like new, dbconsole, server, etc.
This makes the integration cleaner and easier for other third-party
libraries to add to such as RSpec.

@pixeltrix pixeltrix Move commands under Rails::ConsoleMethods namespace
There's an existing module for the console methods app and helper
so it makes sense to move the commands under this module as commands.rb
already exists for other commands like new, dbconsole, server, etc.
This makes the integration cleaner and easier for other third-party
libraries to add to such as RSpec.
6737cf7
Owner

rafaelfranca commented Dec 22, 2012

@pixeltrix it needs rebase

Owner

dhh commented Dec 22, 2012

I already did this after you suggested ;). Thanks though!

I don't think it needs to go under ConsoleMethods. This will be useful for all sorts of things, like Conductor, who want to run commands in-process.

dhh closed this Dec 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment