Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Changed 'args' to 'arguments' when used in places other than code wit…

…h fixing few more typos
  • Loading branch information...
commit d45145acdc576e46a1f1719d69bec96b5bf07b0a 1 parent 12cecdd
@prathamesh-sonpatki prathamesh-sonpatki authored
View
2  actionpack/test/abstract/callbacks_test.rb
@@ -259,7 +259,7 @@ def index(text)
end
class TestCallbacksWithArgs < ActiveSupport::TestCase
- test "callbacks still work when invoking process with multiple args" do
+ test "callbacks still work when invoking process with multiple arguments" do
controller = CallbacksWithArgs.new
controller.process(:index, " Howdy!")
assert_equal "Hello world Howdy!", controller.response_body
View
2  actionpack/test/abstract/collector_test.rb
@@ -42,7 +42,7 @@ class TestCollector < ActiveSupport::TestCase
end
end
- test "generated methods call custom with args received" do
+ test "generated methods call custom with arguments received" do

Such changes in code should not be done in docrails, they must go through a pull request in Rails itself. I'll let @vijaydev handle this while checking/merging, but please make sure to not do such changes in docrails anymore, only doc related changes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
collector = MyCollector.new
collector.html
collector.text(:foo)
View
4 activemodel/CHANGELOG.md
@@ -70,7 +70,7 @@
*Yves Senn*
-* Use BCrypt's `MIN_COST` in the test environment for speedier tests when using `has_secure_pasword`.
+* Use BCrypt's `MIN_COST` in the test environment for speedier tests when using `has_secure_password`.
*Brian Cardarella + Jeremy Kemper + Trevor Turk*
@@ -111,7 +111,7 @@
* Changed `ActiveModel::Serializers::Xml::Serializer#add_associations` to by default
propagate `:skip_types, :dasherize, :camelize` keys to included associations.
- It can be overriden on each association by explicitly specifying the option on one
+ It can be overridden on each association by explicitly specifying the option on one
or more associations
*Anthony Alberto*
View
2  guides/source/active_support_instrumentation.md
@@ -428,7 +428,7 @@ end
```
Defining all those block arguments each time can be tedious. You can easily create an `ActiveSupport::Notifications::Event`
-from block args like this:
+from block arguments like this:
```ruby
ActiveSupport::Notifications.subscribe "process_action.action_controller" do |*args|
View
2  guides/source/command_line.md
@@ -82,7 +82,7 @@ The server can be run on a different port using the `-p` option. The default dev
$ rails server -e production -p 4000
```
-The `-b` option binds Rails to the specified ip, by default it is 0.0.0.0. You can run a server as a daemon by passing a `-d` option.
+The `-b` option binds Rails to the specified IP, by default it is 0.0.0.0. You can run a server as a daemon by passing a `-d` option.
### `rails generate`

7 comments on commit d45145a

@prathamesh-sonpatki
Collaborator

@carlosantoniodasilva Yes. Will take care from next time.

@fxn
Owner

Yep, has to be reverted. Not touching code is a hard rule.

@prathamesh-sonpatki
Collaborator

@fxn, @carlosantoniodasilva Reverted it here 49760c1

@fxn
Owner

Is not enough, CHANGELOGs cannot be edited either in docrails. Please have a look at the contrib guidelines.

@carlosantoniodasilva

Thanks.

@prathamesh-sonpatki
Collaborator

@fxn Thanks. Fixed it in 33d1e37
I will take more care from next time onwards.

@fxn
Owner

Thanks!

Please sign in to comment.
Something went wrong with that request. Please try again.