Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Apr 3, 2015
  1. @iainbeeston

    Raise ArgumentError if an unrecognised callback is skipped

    iainbeeston authored
    At present, if you skip a callback that hasn't been defined,
    activesupport callbacks silently does nothing. However, it's easy to
    mistype the name of a callback and mistakenly think that it's being
    skipped, when it is not.
    
    This problem even exists in the current test suite.
    CallbacksTest::SkipCallbacksTest#test_skip_person attempts to skip
    callbacks that were never set up.
    
    This PR changes `skip_callback` to raise an `ArgumentError` if the
    specified callback cannot be found.
Commits on Feb 27, 2015
  1. @iainbeeston

    Explained how to set session expiry through session_store config

    iainbeeston authored
    Most session stores offer an :expire_after option, but it's largely
    undocumented. Cookie store also supports a number of options via
    rack (these used to be documented in rails 2.3)
Commits on Feb 24, 2015
  1. @iainbeeston

    Deprecate `AbstractController::Callbacks#skip_action_callback`

    iainbeeston authored
    As part of #19029, in future `skip_before_action`, `skip_after_action` and
    `skip_around_action` will raise an ArgumentError if the specified
    callback does not exist. `skip_action_callback` calls all three of these
    methods and will almost certainly result in an ArgumentError. If anyone
    wants to remove all three callbacks then they can still call the three
    individual methods. Therefore let's deprecate `skip_action_callback` now
    and remove it when #19029 is merged.
Commits on Nov 28, 2014
  1. @iainbeeston
Commits on Feb 12, 2014
  1. @iainbeeston

    Added tests to render helper that expect `render partial: @foo` to

    iainbeeston authored
    automatically call @foo.to_partial_path
    
    Calling `render @foo` allows local variables but not options to be
    passed to the partial renderer. The correct way to render an object AND
    pass options to the partial renderer is to pass the object in the
    `:partial` parameter. However, there were previously no tests for this
    behaviour (in `render_helper_test.rb` at least).
Commits on Aug 3, 2013
  1. @iainbeeston

    Updated the guide to say that the localisation file for validation me…

    iainbeeston authored
    …ssages is in activemodel, not activerecord
Commits on Apr 14, 2013
  1. @iainbeeston

    Tried to make the response status code table more readable

    iainbeeston authored
    By making it the last thing in it's section and adding pseudo row headers
Commits on Apr 6, 2013
  1. @iainbeeston
Something went wrong with that request. Please try again.