fix ExecJS::Runtimes.from_environment #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| raise RuntimeUnavailable, "#{runtime.name} runtime is not available on this system" | ||
| end | ||
| elsif !name.empty? | ||
| rescue |
There was a problem hiding this comment.
Can we rescue the specific exception?
Merged
|
Fixed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of sstephenson#156
The current implementation of
ExecJS::Runtimes.from_environmenthas two bad things:elsifbranch can never reached, while theif const_getwill raise a exception. So we should fix it by using a rescue.if