New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation/tests for exec/eval/call #77

merged 5 commits into from Sep 20, 2018


None yet
4 participants

judofyr commented Jun 2, 2018

The following pull request:

  • Adds documentation for Context#exec, #eval and #call
  • Explicitly allows for Context#call to accept any function expression
  • Makes Duktape respect this behavior

This comment has been minimized.

rails-bot commented Jun 2, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

judofyr added some commits Jun 2, 2018

test_call_with_this: Skip on Rhino
This is a known bug in Ruby Rhino

This comment has been minimized.


judofyr commented Jun 6, 2018

@rafaelfranca This is all green now! There's one test case I had to skip on Rhino, but otherwise the engines are more consistent with each other.


This comment has been minimized.


judofyr commented Jun 23, 2018

Any time frame on when this will be looked at?


This comment has been minimized.


judofyr commented Aug 3, 2018

@rafaelfranca @josh @sstephenson Does anyone have time to look at this? This is fixing multiple reported issues (e.g. twbs/bootstrap-rubygem#157).


This comment has been minimized.

Hellfar commented Sep 15, 2018

Up ?
@rafaelfranca how can we help you to review this PR?
It seems pretty important and may be fixing a lot related issues.

@rafaelfranca rafaelfranca merged commit 7dd2a79 into rails:master Sep 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment