Changing the yielding API#68
Merged
Merged
Conversation
Member
|
Love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the API of
Jbuilderto not require an argument for every block. It also fixes the implementation ofcache!to be compatible with this API (see confusion in #63).Old API:
New API:
Documentation has been updated, but the old API actually still works. Keeping backwards compatibility was only an issue for the few methods that take a block with 2 arguments. The first argument used to be an instance of a
Jbuilderobject, the second argument the element for the current iteration. With this change a block with arity 1 only receives the element. The code for that is ugly though. Therefore it would be great if the old API could be deprecated and removed sometime after a major version bump.