Remove support for Rails 3/Rails 3.1 apps. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmazza
force-pushed
the
rails-4-only
branch
from
aebb060
to
2f1b67c
Compare
| @@ -1,3 +1,7 @@ | |||
| ## Master | |||
|
|
|||
| - Removed support for Rails 3 and Rails 3.1 | |||
There was a problem hiding this comment.
This should probably read "Rails <= 4.2" (or something to that effect) to be less confusing to the user reading this 😄
|
🤘 |
lucasmazza
force-pushed
the
rails-4-only
branch
from
2f1b67c
to
4f70054
Compare
rafaelfranca
added a commit
that referenced
this pull request
Sep 1, 2014
Remove support for Rails 3/Rails 3.1 apps.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of the latest discussion at #124 and I'm opening this so it won't be left for dead in a branch.
The idea is to drop support for Rails 3 and ship both jQuery
1.11.xand2.1.xinside the gem. I believe we can ship both JavaScript files insidevendor/assets/javascriptsand everyone will be able to//= requireeitherjquery2orjqueryon their apps without any hassle.I'll also gonna need to update the rake task that download the latest jQuery version to support both 1.11.x and 2.1.x releases, since there isn't a specific URL to grab the latest jQuery 2 script like we do with
http://code.jquery.com/jquery.jsand friends. The expected workflow would be to update theversion.rbfirst and then running the task to download all the assets for the specific versions./summon @JangoSteve