Update jQuery to 1.7 #30

Merged
merged 1 commit into from Nov 9, 2011

Conversation

Projects
None yet
9 participants
@evanwalsh

The new version of jQuery has been released and I've updated the assets and the version file.

@adamyonk

This comment has been minimized.

Show comment
Hide comment
@adamyonk

adamyonk Nov 4, 2011

Ship it!

adamyonk commented Nov 4, 2011

Ship it!

@JangoSteve

This comment has been minimized.

Show comment
Hide comment
@JangoSteve

JangoSteve Nov 4, 2011

Member

Could you rebase these two commits into one please (no need to create a new pull request though, just force push it to update this one)? I'll have to update jquery-ujs with jquery 1.7 and make sure all the tests are passing before pulling this in.

Member

JangoSteve commented Nov 4, 2011

Could you rebase these two commits into one please (no need to create a new pull request though, just force push it to update this one)? I'll have to update jquery-ujs with jquery 1.7 and make sure all the tests are passing before pulling this in.

@evanwalsh

This comment has been minimized.

Show comment
Hide comment
@evanwalsh

evanwalsh Nov 4, 2011

All right. Commit dbfa580 should have all the changes needed. Still getting the hang of this advanced git stuff. Thanks!

All right. Commit dbfa580 should have all the changes needed. Still getting the hang of this advanced git stuff. Thanks!

@kaluznyo

This comment has been minimized.

Show comment
Hide comment
@kaluznyo

kaluznyo Nov 7, 2011

up ?

kaluznyo commented Nov 7, 2011

up ?

@halorgium

This comment has been minimized.

Show comment
Hide comment
@halorgium

halorgium Nov 8, 2011

halorgium@f60adfa has the squashed commit.
I can't seem to push to this pull request.

halorgium@f60adfa has the squashed commit.
I can't seem to push to this pull request.

@JangoSteve

This comment has been minimized.

Show comment
Hide comment
@JangoSteve

JangoSteve Nov 8, 2011

Member

@evanwalsh, you now have 4 commits in this pull request instead of one. You can squash the commits down by doing an interactive rebase. Then force-push them to your master branch with git push -f origin master. That will then automatically update this pull request.

Member

JangoSteve commented Nov 8, 2011

@evanwalsh, you now have 4 commits in this pull request instead of one. You can squash the commits down by doing an interactive rebase. Then force-push them to your master branch with git push -f origin master. That will then automatically update this pull request.

@overture8

This comment has been minimized.

Show comment
Hide comment
@overture8

overture8 Nov 8, 2011

+1

+1

@kenips

This comment has been minimized.

Show comment
Hide comment
@kenips

kenips Nov 9, 2011

What is the planned version number for the next release? I'd like to see it moving to 1.1.x since jQuery 1.7 has some major changes. That way I can make sure all the old projects are capped at 1.0.x until they are ready for jQuery 1.7.

kenips commented Nov 9, 2011

What is the planned version number for the next release? I'd like to see it moving to 1.1.x since jQuery 1.7 has some major changes. That way I can make sure all the old projects are capped at 1.0.x until they are ready for jQuery 1.7.

@nicolai86

This comment has been minimized.

Show comment
Hide comment
@nicolai86

nicolai86 Nov 9, 2011

+1

+1

@evanwalsh

This comment has been minimized.

Show comment
Hide comment
@evanwalsh

evanwalsh Nov 9, 2011

There. Finally got it. Thanks for your help, @JangoSteve.

There. Finally got it. Thanks for your help, @JangoSteve.

@JangoSteve

This comment has been minimized.

Show comment
Hide comment
@JangoSteve

JangoSteve Nov 9, 2011

Member

@evanwalsh, almost there! Now you checked in a merge conflict in https://github.com/rails/jquery-rails/pull/30/files#diff-0. Fix that and I'll pull this in in the morning.

Member

JangoSteve commented Nov 9, 2011

@evanwalsh, almost there! Now you checked in a merge conflict in https://github.com/rails/jquery-rails/pull/30/files#diff-0. Fix that and I'll pull this in in the morning.

@evanwalsh

This comment has been minimized.

Show comment
Hide comment
@evanwalsh

evanwalsh Nov 9, 2011

Ok. I fixed it.

My first pull request and this is what happens @_@.

Ok. I fixed it.

My first pull request and this is what happens @_@.

@kenips

This comment has been minimized.

Show comment
Hide comment
@kenips

kenips Nov 9, 2011

Note that we're also hitting the following jQuery 1.7 deprecations in jquery_ujs.js

.live(): line 289, 293, 309, 317, 347, 359, 363
.data(“events”): line 255

The .live()s are easy to fix with .on(), but I'm not sure how to go about fixing .data("events").

kenips commented Nov 9, 2011

Note that we're also hitting the following jQuery 1.7 deprecations in jquery_ujs.js

.live(): line 289, 293, 309, 317, 347, 359, 363
.data(“events”): line 255

The .live()s are easy to fix with .on(), but I'm not sure how to go about fixing .data("events").

@vizjerai

This comment has been minimized.

Show comment
Hide comment
@vizjerai

vizjerai Nov 9, 2011

.data("events") is supposed to be accessible through .events If that doesn't work they could be read through an internal method ._data(element, "events") But it may get removed or renamed in the future.

source: http://blog.jquery.com/2011/11/08/building-a-slimmer-jquery/

vizjerai commented Nov 9, 2011

.data("events") is supposed to be accessible through .events If that doesn't work they could be read through an internal method ._data(element, "events") But it may get removed or renamed in the future.

source: http://blog.jquery.com/2011/11/08/building-a-slimmer-jquery/

@JangoSteve

This comment has been minimized.

Show comment
Hide comment
@JangoSteve

JangoSteve Nov 9, 2011

Member

@kenips and @vizjerai, that'll all be taken care of over on rails/jquery-ujs. We can continue the discussion there if you'd like.

@evanwalsh haha no worries. The first of many in your open-source career ;-)

Member

JangoSteve commented Nov 9, 2011

@kenips and @vizjerai, that'll all be taken care of over on rails/jquery-ujs. We can continue the discussion there if you'd like.

@evanwalsh haha no worries. The first of many in your open-source career ;-)

@JangoSteve JangoSteve merged commit d03c90e into rails:master Nov 9, 2011

@kenips

This comment has been minimized.

Show comment
Hide comment
@kenips

kenips Nov 9, 2011

@JangoSteve sounds good. If version bump could happen after pulling-in new ujs that'd be great.

kenips commented Nov 9, 2011

@JangoSteve sounds good. If version bump could happen after pulling-in new ujs that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment