The new version of jQuery has been released and I've updated the assets and the version file.
Could you rebase these two commits into one please (no need to create a new pull request though, just force push it to update this one)? I'll have to update jquery-ujs with jquery 1.7 and make sure all the tests are passing before pulling this in.
All right. Commit dbfa580 should have all the changes needed. Still getting the hang of this advanced git stuff. Thanks!
halorgium@f60adfa has the squashed commit.
I can't seem to push to this pull request.
@evanwalsh, you now have 4 commits in this pull request instead of one. You can squash the commits down by doing an interactive rebase. Then force-push them to your master branch with git push -f origin master. That will then automatically update this pull request.
git push -f origin master
What is the planned version number for the next release? I'd like to see it moving to 1.1.x since jQuery 1.7 has some major changes. That way I can make sure all the old projects are capped at 1.0.x until they are ready for jQuery 1.7.
There. Finally got it. Thanks for your help, @JangoSteve.
@evanwalsh, almost there! Now you checked in a merge conflict in https://github.com/rails/jquery-rails/pull/30/files#diff-0. Fix that and I'll pull this in in the morning.
Update to jQuery 1.7.0
Ok. I fixed it.
My first pull request and this is what happens @_@.
Note that we're also hitting the following jQuery 1.7 deprecations in jquery_ujs.js
.live(): line 289, 293, 309, 317, 347, 359, 363
.data(“events”): line 255
The .live()s are easy to fix with .on(), but I'm not sure how to go about fixing .data("events").
.data("events") is supposed to be accessible through .events If that doesn't work they could be read through an internal method ._data(element, "events") But it may get removed or renamed in the future.
@kenips and @vizjerai, that'll all be taken care of over on rails/jquery-ujs. We can continue the discussion there if you'd like.
@evanwalsh haha no worries. The first of many in your open-source career ;-)
@JangoSteve sounds good. If version bump could happen after pulling-in new ujs that'd be great.