Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix jQuery version constant #97

Merged
merged 1 commit into from

3 participants

@ai
ai commented

Fix JQUERY_VERSION.

@JangoSteve JangoSteve merged commit 01e32a6 into rails:master
@ai
ai commented

What about #98 . It’s not a first issue in version constant.

@JangoSteve
Owner

I think we like explicitly having the version numbers written in that file. Makes it easy and convenient to see what's included.

@ai
ai commented

Hm. Maybe we should add Travis task, to detect wrong version on pull request or push?

@kenn kenn referenced this pull request in kenn/jquery-rails-cdn
Closed

Jquery.js is correct, but google cdn version is still 1.8.3 #15

@kenn

Could you point release this fix? jquery-rails-cdn depends on this constant and needs this fix. kenn/jquery-rails-cdn#15

@JangoSteve
Owner

Just pushed 2.2.1. Also includes latest jquery-ujs and jquery 1.9.1.

@JangoSteve
Owner

@ai We use rake release to tag, push to Github, and release on Rubygems.org. Maybe we could override the release task to have it cross-check the version numbers, abort if they're mismatched, and delegate to the existing release task if everything is okay. If someone wanted to submit that, I'd pull it in.

@kenn kenn referenced this pull request from a commit in kenn/jquery-rails
@kenn kenn Check version before rake release. Refs #97 7c0ee2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 21, 2013
  1. @ai

    Fix jQuery version constant

    ai authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/jquery/rails/version.rb
View
2  lib/jquery/rails/version.rb
@@ -1,7 +1,7 @@
module Jquery
module Rails
VERSION = "2.2.0"
- JQUERY_VERSION = "1.8.3"
+ JQUERY_VERSION = "1.9.0"
JQUERY_UI_VERSION = "1.9.2"
JQUERY_UJS_VERSION = "bddff6a677edc54f00e48bde740b0b22d68deef6"
end
Something went wrong with that request. Please try again.